[Lldb-commits] [lldb] [lldb] Compare registers by LLDB register number (PR #223704)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp,h -- lldb/include/lldb/ValueObject/ValueObjectRegister.h lldb/source/ValueObject/ValueObjectRegister.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/ValueObject/ValueObjectRegister.cpp b/lldb/source/ValueObject/ValueObjectRegister.cpp
index b9f933836..1a7a45607 100644
--- a/lldb/source/ValueObject/ValueObjectRegister.cpp
+++ b/lldb/source/ValueObject/ValueObjectRegister.cpp
@@ -128,8 +128,7 @@ ValueObject *ValueObjectRegisterSet::CreateChildAtIndex(size_t idx) {
 
 bool ValueObjectRegisterSet::IsSameRegister(const RegisterInfo *a,
                                             const RegisterInfo *b) {
-  return a && b &&
-         a->kinds[eRegisterKindLLDB] == b->kinds[eRegisterKindLLDB];
+  return a && b && a->kinds[eRegisterKindLLDB] == b->kinds[eRegisterKindLLDB];
 }
 
 std::optional<std::pair<size_t, const RegisterInfo *>>

``````````

</details>


https://github.com/llvm/llvm-project/pull/223704