[Lldb-commits] [lldb] [lldb] Memory cache: no overlap and read across cache entries (PR #222688)

[Yao Qi via lldb-commits]

================
@@ -12,12 +12,97 @@
 #include "lldb/Utility/RangeMap.h"
 #include "lldb/lldb-private.h"
 #include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/DenseMap.h"
 #include "llvm/ADT/SmallVector.h"
 #include <map>
+#include <memory>
 #include <mutex>
 #include <vector>
 
 namespace lldb_private {
+
+/// A set of whole, aligned cache lines, keyed by line index.  A key names a
+/// whole line, so no entry can be partial or unaligned and no length is
+/// stored per entry.
----------------
qiyao wrote:

Correct, I meant the cache entry carries no length field, not that no length exists anywhere.  I remove "no length is stored per entry". 

The cache line size is not known on compile-time, it is from `target.process.memory-cache-line-size`.

https://github.com/llvm/llvm-project/pull/222688