[Lldb-commits] [lldb] [lldb] Memory cache: no overlap and read across cache entries (PR #222688)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -58,41 +144,44 @@ class MemoryCache {
                     const lldb::DataBufferSP &data_buffer_sp);
 
 protected:
-  typedef std::map<lldb::addr_t, lldb::DataBufferSP> BlockMap;
   typedef RangeVector<lldb::addr_t, lldb::addr_t, 4> InvalidRanges;
   typedef Range<lldb::addr_t, lldb::addr_t> AddrRange;
   // Classes that inherit from MemoryCache can see and modify these
   std::recursive_mutex m_mutex;
-  BlockMap m_L1_cache; // A first level memory cache whose chunk sizes vary that
-                       // will be used only if the memory read fits entirely in
-                       // a chunk
-  BlockMap m_L2_cache; // A memory cache of fixed size chinks
-                       // (m_L2_cache_line_byte_size bytes in size each)
+  // L1 and L2 partition the cache.  An address is held by at most one.  L2
----------------
felipepiovezan wrote:

Nit: extra whitespaces at the end of both sentences

https://github.com/llvm/llvm-project/pull/222688