[Lldb-commits] [lldb] [lldb][test] Fix RegisterValueTest.cpp compile with GCC (PR #222889)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/222889

Avoid some most vexing parse problems.

Fixes #220707 / 19eb8bf1a5fd01e2bca2c7112b7f393f946d67f4.

>From 0e4a9b0c8e3ab939ba69c1daff44130e748f4004 Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at arm.com>
Date: Fri, 11 Sep 2026 09:00:25 +0000
Subject: [PATCH] [lldb][test] Fix RegisterValueTest.cpp compile with GCC

Avoid some most vexing parse problems.
---
 lldb/unittests/Utility/RegisterValueTest.cpp | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/lldb/unittests/Utility/RegisterValueTest.cpp b/lldb/unittests/Utility/RegisterValueTest.cpp
index 6a20335a15636..24f24a978d7cb 100644
--- a/lldb/unittests/Utility/RegisterValueTest.cpp
+++ b/lldb/unittests/Utility/RegisterValueTest.cpp
@@ -91,8 +91,8 @@ TEST(RegisterValueTest, GetDataInTargetByteOrder) {
       llvm::ArrayRef(little_endian_bytes));
 
   uint8_t padded_big_endian_bytes[] = {0x00, 0x01, 0x02, 0x03};
-  RegisterValue padded_value(llvm::ArrayRef(padded_big_endian_bytes),
-                             lldb::eByteOrderBig);
+  RegisterValue padded_value = RegisterValue(
+      llvm::ArrayRef(padded_big_endian_bytes), lldb::eByteOrderBig);
   ASSERT_TRUE(padded_value.GetData(target_data, reg_info.byte_size,
                                    lldb::eByteOrderBig));
   EXPECT_EQ(
@@ -102,16 +102,19 @@ TEST(RegisterValueTest, GetDataInTargetByteOrder) {
 
 TEST(RegisterValueTest, GetDataRejectsUnsupportedByteOrder) {
   uint8_t bytes[] = {0x01, 0x02, 0x03};
+  llvm::ArrayRef bytes_ref(bytes);
   DataExtractor data;
 
-  RegisterValue invalid_source(llvm::ArrayRef(bytes), lldb::eByteOrderInvalid);
+  RegisterValue invalid_source =
+      RegisterValue(bytes_ref, lldb::eByteOrderInvalid);
   EXPECT_FALSE(
       invalid_source.GetData(data, sizeof(bytes), lldb::eByteOrderLittle));
 
-  RegisterValue pdp_source(llvm::ArrayRef(bytes), lldb::eByteOrderPDP);
+  RegisterValue pdp_source = RegisterValue(bytes_ref, lldb::eByteOrderPDP);
   EXPECT_FALSE(pdp_source.GetData(data, sizeof(bytes), lldb::eByteOrderLittle));
 
-  RegisterValue little_source(llvm::ArrayRef(bytes), lldb::eByteOrderLittle);
+  RegisterValue little_source =
+      RegisterValue(bytes_ref, lldb::eByteOrderLittle);
   EXPECT_FALSE(
       little_source.GetData(data, sizeof(bytes), lldb::eByteOrderInvalid));
   EXPECT_FALSE(little_source.GetData(data, sizeof(bytes), lldb::eByteOrderPDP));