[Lldb-commits] [lldb] [lldb][4/5] Expose vector registers through SBValue (PR #220707)

[David Spickett via lldb-commits]

================
@@ -258,7 +270,16 @@ bool ValueObjectRegister::UpdateValue() {
   if (m_reg_ctx_sp) {
     RegisterValue m_old_reg_value(m_reg_value);
     if (m_reg_ctx_sp->ReadRegister(&m_reg_info, m_reg_value)) {
-      if (m_reg_value.GetData(m_data)) {
+      Target *target = exe_ctx.GetTargetPtr();
+      const bool has_vector_type =
+          llvm::isa_and_present<RegisterTypeVector>(m_reg_info.register_type);
+      // CompilerType children interpret bytes using the target's layout.
----------------
DavidSpickett wrote:

I have a feeling we could sink this check deeper to reduce the number of times we have to check it, but I assume you thought that through and it's not possible.

Plus it is within ValueObjectRegister still, so it's well contained.

https://github.com/llvm/llvm-project/pull/220707