[Lldb-commits] [lldb] [lldb] Handle implicit values followed by full-width piece operations (PR #219160)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 27 02:47:53 PDT 2026
https://github.com/MrEven132 created https://github.com/llvm/llvm-project/pull/219160
`DW_OP_implicit_value` stores its bytes in a `Value` whose internal type is `HostAddress`. The `DW_OP_piece` and `DW_OP_bit_piece` evaluators therefore mistook the backing-buffer address for a memory location and rejected valid full-width pieces.
Use the saved implicit location-description kind to recognize this storage representation. Full-width byte pieces and zero-offset full-width bit pieces now preserve the backing bytes, while genuine host addresses and partial pieces retain their existing behavior.
Add a unit test for both expressions from the issue.
Fixes #203224
>From 68b72f1ec0c1ef230f51859c46c310639e1f8e28 Mon Sep 17 00:00:00 2001
From: MrEven132 <13554966229 at 163.com>
Date: Thu, 27 Aug 2026 17:43:42 +0800
Subject: [PATCH] [lldb] Handle implicit values followed by full-width piece
operations
---
lldb/source/Expression/DWARFExpression.cpp | 23 ++++++++++++++++++-
.../Expression/DWARFExpressionTest.cpp | 11 +++++++++
2 files changed, 33 insertions(+), 1 deletion(-)
diff --git a/lldb/source/Expression/DWARFExpression.cpp b/lldb/source/Expression/DWARFExpression.cpp
index e62b6945dc3ed..1594ce070955f 100644
--- a/lldb/source/Expression/DWARFExpression.cpp
+++ b/lldb/source/Expression/DWARFExpression.cpp
@@ -1182,6 +1182,15 @@ static llvm::Error Evaluate_DW_OP_piece(EvalContext &eval_ctx,
}
} break;
case Value::ValueType::HostAddress: {
+ // DW_OP_implicit_value uses a host-address Value to own its bytes. For
+ // a full-width piece, the address is only an implementation detail and
+ // the backing bytes are the value of the piece.
+ if (piece_locdesc == Implicit &&
+ curr_piece_source_value.GetBuffer().GetByteSize() ==
+ piece_byte_size) {
+ curr_piece = curr_piece_source_value;
+ break;
+ }
return llvm::createStringError(
"failed to read memory DW_OP_piece(%" PRIu64
") from host address 0x%" PRIx64,
@@ -2001,7 +2010,8 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
return llvm::createStringError(
"expression stack needs at least 1 item for DW_OP_bit_piece");
} else {
- UpdateValueTypeFromLocationDescription(eval_ctx, eval_ctx.loc_desc_kind,
+ const LocationDescriptionKind piece_locdesc = eval_ctx.loc_desc_kind;
+ UpdateValueTypeFromLocationDescription(eval_ctx, piece_locdesc,
&stack.back());
// Reset for the next piece.
eval_ctx.loc_desc_kind = Memory;
@@ -2024,7 +2034,18 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
case Value::ValueType::FileAddress:
case Value::ValueType::LoadAddress:
+ return llvm::createStringError(
+ "unable to extract DW_OP_bit_piece(bit_size = %" PRIu64
+ ", bit_offset = %" PRIu64 ") from an address value.",
+ piece_bit_size, piece_bit_offset);
+
case Value::ValueType::HostAddress:
+ // As above, a full-width DW_OP_implicit_value piece refers to the
+ // backing bytes, not the address of that backing storage.
+ if (piece_locdesc == Implicit && piece_bit_offset == 0 &&
+ piece_bit_size % 8 == 0 &&
+ stack.back().GetBuffer().GetByteSize() == piece_bit_size / 8)
+ break;
return llvm::createStringError(
"unable to extract DW_OP_bit_piece(bit_size = %" PRIu64
", bit_offset = %" PRIu64 ") from an address value.",
diff --git a/lldb/unittests/Expression/DWARFExpressionTest.cpp b/lldb/unittests/Expression/DWARFExpressionTest.cpp
index 76d2d4efcf557..97a435cb47c4e 100644
--- a/lldb/unittests/Expression/DWARFExpressionTest.cpp
+++ b/lldb/unittests/Expression/DWARFExpressionTest.cpp
@@ -891,6 +891,17 @@ TEST(DWARFExpression, DW_OP_implicit_value) {
llvm::HasValue(0x40302010u));
}
+TEST(DWARFExpression, DW_OP_implicit_value_piece) {
+ const std::vector<uint8_t> expected = {0x9c, 0xee, 0x4c, 0x86};
+
+ EXPECT_THAT_EXPECTED(Evaluate({DW_OP_implicit_value, 4, 0x9c, 0xee, 0x4c,
+ 0x86, DW_OP_piece, 4}),
+ ExpectHostAddress(expected));
+ EXPECT_THAT_EXPECTED(Evaluate({DW_OP_implicit_value, 4, 0x9c, 0xee, 0x4c,
+ 0x86, DW_OP_bit_piece, 32, 0}),
+ ExpectHostAddress(expected));
+}
+
TEST(DWARFExpression, DW_OP_unknown) {
EXPECT_THAT_EXPECTED(
Evaluate({0xff}),
More information about the lldb-commits
mailing list