[Lldb-commits] [lldb] [lldb] Compare generic DWARF relational operands as signed values (PR #218335)

via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 24 21:55:30 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- lldb/source/Expression/DWARFExpression.cpp lldb/unittests/Expression/DWARFExpressionTest.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Expression/DWARFExpression.cpp b/lldb/source/Expression/DWARFExpression.cpp
index 4e6875753..453c361c1 100644
--- a/lldb/source/Expression/DWARFExpression.cpp
+++ b/lldb/source/Expression/DWARFExpression.cpp
@@ -1755,7 +1755,8 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
       tmp = stack.back();
       stack.pop_back();
       if (IsPotentiallyGenericIntegerOperand(tmp.GetScalar(), address_size) &&
-          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(), address_size)) {
+          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(),
+                                             address_size)) {
         tmp.GetScalar().MakeSigned();
         stack.back().GetScalar().MakeSigned();
       }
@@ -1771,7 +1772,8 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
       tmp = stack.back();
       stack.pop_back();
       if (IsPotentiallyGenericIntegerOperand(tmp.GetScalar(), address_size) &&
-          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(), address_size)) {
+          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(),
+                                             address_size)) {
         tmp.GetScalar().MakeSigned();
         stack.back().GetScalar().MakeSigned();
       }
@@ -1787,7 +1789,8 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
       tmp = stack.back();
       stack.pop_back();
       if (IsPotentiallyGenericIntegerOperand(tmp.GetScalar(), address_size) &&
-          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(), address_size)) {
+          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(),
+                                             address_size)) {
         tmp.GetScalar().MakeSigned();
         stack.back().GetScalar().MakeSigned();
       }
@@ -1803,7 +1806,8 @@ llvm::Expected<Value> DWARFExpression::Evaluate(
       tmp = stack.back();
       stack.pop_back();
       if (IsPotentiallyGenericIntegerOperand(tmp.GetScalar(), address_size) &&
-          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(), address_size)) {
+          IsPotentiallyGenericIntegerOperand(stack.back().GetScalar(),
+                                             address_size)) {
         tmp.GetScalar().MakeSigned();
         stack.back().GetScalar().MakeSigned();
       }

``````````

</details>


https://github.com/llvm/llvm-project/pull/218335


More information about the lldb-commits mailing list