[Lldb-commits] [lldb] [lldb] Prefer readers with detailed debug information (PR #218030)

[Jonas Devlieghere via lldb-commits]

https://github.com/JDevlieghere requested changes to this pull request.

Aren't the two changes cancelling each other out? The change to `SymbolFileDWARF` makes the line table conditional on the debug info (which matches your first claim) but the only way to outrank SymbolFileSymtab is if you return only `LineTables`. 

It looks like the fix you want it to check `CompileUnits`. LineTables only shouldn't  win without a CompileUnit to attach it to. SymbolFilePDB::CalculateAbilities returns exactly LineTables when the Symbols table is empty and LineNumbers is not, and with this change it now outranks SymbolFileSymtab. I think that if you require CompileUnits alongside LineTables in the predicate, you fix PDB too and you can drop the SymbolFileDWARF change.

https://github.com/llvm/llvm-project/pull/218030