[Lldb-commits] [lldb] [lldb] Add GDB remote register vector types (PR #217128)

[David Spickett via lldb-commits]

================
@@ -136,12 +154,27 @@ void lldb_private::DumpRegisterValue(const RegisterValue &reg_val, Stream &s,
   // Use a new stream so we can remove a trailing newline later.
   StreamString register_type_stream;
 
-  if (reg_info.byte_size == 4) {
-    dump_type_value(*flags_type, register_compiler_type, reg_val.GetAsUInt32(),
-                    exe_scope, register_type_stream);
+  if (flags_type) {
+    if (reg_info.byte_size == 4) {
+      dump_type_value(*flags_type, register_compiler_type,
+                      reg_val.GetAsUInt32(), exe_scope, register_type_stream);
+    } else if (reg_info.byte_size == 8) {
+      dump_type_value(*flags_type, register_compiler_type,
+                      reg_val.GetAsUInt64(), exe_scope, register_type_stream);
+    } else {
+      return;
+    }
----------------
DavidSpickett wrote:

Somewhere in this an endian hack disappeared, I guess it moved into the value object and I'll find it later.

https://github.com/llvm/llvm-project/pull/217128