[Lldb-commits] [lldb] [lldb] Add GDB remote register vector types (PR #217128)

[David Spickett via lldb-commits]

================
@@ -67,6 +74,54 @@ class RegisterType {
   std::vector<const RegisterType *> m_dependencies;
 };
 
+/// A predefined GDB target-description type.
+class RegisterTypeBuiltin : public RegisterType {
+public:
+  /// A byte size of zero means the size is target-dependent.
+  RegisterTypeBuiltin(std::string id, lldb::Encoding encoding,
+                      lldb::Format format, uint32_t byte_size);
----------------
DavidSpickett wrote:

A bit confusing that the base GetByteSize returns an optional but this takes a value and zero means it doesn't have one (or has one later), then this class' GetByteSize has to account for that zero.

Could this class also take optional for the size?

https://github.com/llvm/llvm-project/pull/217128