[Lldb-commits] [lldb] [lldb] Add MSVC STL formatter for std::valarray (PR #217242)

[via lldb-commits]

================
@@ -182,3 +183,44 @@ def do_test(self):
     def test_libcxx(self):
         self.build(dictionary={"USE_LIBCPP": 1})
         self.do_test()
+
+    @add_test_categories(["libstdcxx"])
+    def test_libstdcxx_not_stolen_by_msvc(self):
+        """libstdc++ valarray must not get the MSVC size=raw-field-count summary."""
+        self.build(dictionary={"USE_LIBSTDCPP": 1})
+        lldbutil.run_to_source_breakpoint(
+            self, "break here", lldb.SBFileSpec("main.cpp", False)
+        )
+        va = self.expect_var_path("va_int")
+        self.assertNotEqual(va.summary, "size=2")
+
+    @add_test_categories(["msvcstl"])
+    def test_msvcstl(self):
----------------
Nerixyz wrote:

I didn't notice before: Can you extract the checks for `std::valarray` from `do_test` and call that method here? That way both STLs use the same checks. You can add checks for `va_empty` and `va_ref` in there.

https://github.com/llvm/llvm-project/pull/217242