[Lldb-commits] [lldb] [lldb] Clear error in Target::ReadMemory before calling Process::ReadMemory (PR #217148)

[via lldb-commits]

jimingham wrote:

> > It's a little ugly that a few of the Process classes override ReadMemory and not DoReadMemory,
> 
> Is it too late for us to make only _one_ of these methods virtual?

I don't know whether it was the original intent but it looks like  Process::DoReadMemory is the implementation if you are using the memory cache, and process plugins that don't use the memory cache override ReadMemory.

We can change any of this since it's all lldb_private.  But if we're going to, we should have process ReadMemory check whether the plugin uses the memory cache and skip directly to DoReadMemory if the answer is no.  Then all the plugins could switch to DoReadMemory.

https://github.com/llvm/llvm-project/pull/217148