[Lldb-commits] [lldb] dcc7330 - [lldb] Fix dotest.py --help (#216131)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Aug 13 14:03:34 PDT 2026
Author: Dave Lee
Date: 2026-08-13T14:03:30-07:00
New Revision: dcc7330c1ac270efe9225b42e9f6d2b574bdbf2c
URL: https://github.com/llvm/llvm-project/commit/dcc7330c1ac270efe9225b42e9f6d2b574bdbf2c
DIFF: https://github.com/llvm/llvm-project/commit/dcc7330c1ac270efe9225b42e9f6d2b574bdbf2c.diff
LOG: [lldb] Fix dotest.py --help (#216131)
Fixes the following `--help` bug I ran into:
```
% python3 ./lldb/test/API/dotest.py --help
Traceback (most recent call last):
File "path/to/llvm-project/lldb/test/API/dotest.py", line 8, in <module>
lldbsuite.test.run_suite()
File "path/to/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 1099, in run_suite
parseOptionsAndInitTestdirs()
File "path/to/llvm-project/lldb/packages/Python/lldbsuite/test/dotest.py", line 318, in parseOptionsAndInitTestdirs
configuration.cmake_build_type = args.cmake_build_type.lower()
AttributeError: 'NoneType' object has no attribute 'lower'
```
Added:
Modified:
lldb/packages/Python/lldbsuite/test/dotest.py
Removed:
################################################################################
diff --git a/lldb/packages/Python/lldbsuite/test/dotest.py b/lldb/packages/Python/lldbsuite/test/dotest.py
index 6555c60dc3bff..dec46c7715e40 100644
--- a/lldb/packages/Python/lldbsuite/test/dotest.py
+++ b/lldb/packages/Python/lldbsuite/test/dotest.py
@@ -316,7 +316,8 @@ def parseOptionsAndInitTestdirs():
configuration.libcxx_include_target_dir = None
configuration.libcxx_library_dir = None
- configuration.cmake_build_type = args.cmake_build_type.lower()
+ if args.cmake_build_type:
+ configuration.cmake_build_type = args.cmake_build_type.lower()
if args.channels:
lldbtest_config.channels = args.channels
More information about the lldb-commits
mailing list