[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add function to lookup ptrace set number (PR #213975)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 13 06:33:26 PDT 2026


DavidSpickett wrote:

> Anyway, this LGTM, but this function could benefit from a assert(llvm::has_single_bit(static_cast<uint32_t>(set)) && "GetPtraceSet expects a single set"), but otherwise this LGTM.

That's a good idea I hadn't thought of that.

There will be more functions that want only one than want multiple, so I'll try to address them all in a follow up. The bit mask aspect of it is mostly to make storing the valid map easier, but maybe I can do that differently and not need the masking feature.

https://github.com/llvm/llvm-project/pull/213975


More information about the lldb-commits mailing list