[Lldb-commits] [lldb] [lldb] Swap the architecture comparison. (PR #214771)
Ebuka Ezike via lldb-commits
lldb-commits at lists.llvm.org
Fri Aug 7 09:21:38 PDT 2026
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/214771
>From 4a3edc861bd748ea6467294b0fa508465e89f240 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <e_ezike at apple.com>
Date: Fri, 7 Aug 2026 16:07:32 +0100
Subject: [PATCH 1/2] [lldb] Swap the architecture comparison.
The arm architecture has different variants (arm64, armv8l e.t.c).
We only want check if it contains the arm prefix.
---
.../TestGdbRemoteTargetXmlPacket.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py b/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
index d873fbe04c825..52c31607091fa 100644
--- a/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
+++ b/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
@@ -48,7 +48,7 @@ def test_g_target_xml_returns_correct_data(self):
}
arch: str = self.getArchitecture()
expected_arch = replaced_arch.get(arch, arch)
- self.assertIn(architecture.text, expected_arch)
+ self.assertIn(expected_arch, architecture.text)
feature = root.find("feature")
self.assertIsNotNone(feature)
>From 05b4bc8b7b25252536a79b7d3ed9261fdd53b0de Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Fri, 7 Aug 2026 17:21:24 +0100
Subject: [PATCH 2/2] use startswith
---
.../TestGdbRemoteTargetXmlPacket.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py b/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
index 52c31607091fa..c8f45c24f9546 100644
--- a/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
+++ b/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
@@ -48,7 +48,7 @@ def test_g_target_xml_returns_correct_data(self):
}
arch: str = self.getArchitecture()
expected_arch = replaced_arch.get(arch, arch)
- self.assertIn(expected_arch, architecture.text)
+ self.assertTrue(architecture.text.startswith(expected_arch))
feature = root.find("feature")
self.assertIsNotNone(feature)
More information about the lldb-commits
mailing list