[Lldb-commits] [lldb] [lldb] Wrap Target::GetAPIMutex() into a Lockable handle (NFC) (PR #212872)

[Jonas Devlieghere via lldb-commits]

================
@@ -36,12 +38,12 @@ class LLDB_API SBMutex {
   bool try_lock() const;
 
 private:
-  // Private constructor used by SBTarget to create the Target API mutex.
-  // Requires a friend declaration.
   SBMutex(lldb::TargetSP target_sp);
   friend class SBTarget;
 
-  std::shared_ptr<std::recursive_mutex> m_opaque_sp;
+  // Set instead of m_opaque_sp when constructed without a target.
+  std::shared_ptr<std::recursive_mutex> m_owned_mutex;
+  std::shared_ptr<lldb_private::TargetAPILock> m_opaque_sp;
----------------
JDevlieghere wrote:

This is an ABI break. I also don't understand why you would need both?

https://github.com/llvm/llvm-project/pull/212872