[Lldb-commits] [lldb] [lldb] Scope Wasm global reads to a module instance (PR #213176)

[Jason Molenda via lldb-commits]

jasonmolenda wrote:

Thanks this answers all my questions.  

One thing I was thinking about is that wasm32 may have other places where an "address" is really "module instance ID + the index of something" and not really an address in an address space like we think of it.  I think the `instance:` key is going to be clearer if this is more often the meaning.  But if instances have distinct address spaces like "the variable occupying byte range 0x100-0x120 in instance 5" then it really does look more like an address space, and in the memory read/write packets it would look more natural as an `address_space` (and we would probably use the same address space infrastructure in lldb that the other PR is working towards).

I have so little experience with the wasm communications/interface I'm not sure I should approve this, but I'm good from here.

https://github.com/llvm/llvm-project/pull/213176