[Lldb-commits] [lldb] [lldb] Fix compilation error in ThreadPlanBase fallback tracer (PR #213581)

[saif elden via lldb-commits]

https://github.com/saifelden1 created https://github.com/llvm/llvm-project/pull/213581


Fixes a build failure in ThreadPlanBase::ThreadPlanBase when THREAD_PLAN_USE_ASSEMBLY_TRACER is disabled/undefined.

In lldb/source/Target/ThreadPlanBase.cpp the #else fallback branch attempts to instantiate ThreadPlanTracer using m_thread

However, m_thread is a pointer (Thread *) in ThreadPlan.h, whereas the ThreadPlanTracer constructor expects a reference (Thread &).

This PR updates the argument to thread (matching ThreadPlanAssemblyTracer(thread) in the #ifdef block), resolving the compilation error when the fallback branch is taken.

>From 16e24e0ab3b5f0deca282462dfbb61bc65b48498 Mon Sep 17 00:00:00 2001
From: saif elden <123162932+saifelden1 at users.noreply.github.com>
Date: Mon, 3 Aug 2026 05:56:18 +0300
Subject: [PATCH] [lldb] Fix compilation error in ThreadPlanBase fallback
 tracer

---
 lldb/source/Target/ThreadPlanBase.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lldb/source/Target/ThreadPlanBase.cpp b/lldb/source/Target/ThreadPlanBase.cpp
index d4529895a61d7..c8988e9f374ea 100644
--- a/lldb/source/Target/ThreadPlanBase.cpp
+++ b/lldb/source/Target/ThreadPlanBase.cpp
@@ -37,7 +37,7 @@ ThreadPlanBase::ThreadPlanBase(Thread &thread)
 #ifdef THREAD_PLAN_USE_ASSEMBLY_TRACER
   ThreadPlanTracerSP new_tracer_sp(new ThreadPlanAssemblyTracer(thread));
 #else
-  ThreadPlanTracerSP new_tracer_sp(new ThreadPlanTracer(m_thread));
+  ThreadPlanTracerSP new_tracer_sp(new ThreadPlanTracer(thread));
 #endif
   new_tracer_sp->EnableTracing(thread.GetTraceEnabledState());
   SetThreadPlanTracer(new_tracer_sp);