[Lldb-commits] [lldb] [lldb] Fix typo in SBUnixSignals.get_unix_signals_list (PR #213527)
via lldb-commits
lldb-commits at lists.llvm.org
Sun Aug 2 04:05:03 PDT 2026
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/213527
Found when looking through the generated Python file. `sig` doesn't exist in that context, it should be `idx`.
>From 1d011219de34c1627ed51e0cdddb97c0df533204 Mon Sep 17 00:00:00 2001
From: Nerixyz <nerixdev at outlook.de>
Date: Sun, 2 Aug 2026 13:01:48 +0200
Subject: [PATCH] [lldb] Fix typo in SBUnixSignals.get_unix_signals_list
---
lldb/bindings/interface/SBUnixSignalsExtensions.i | 2 +-
lldb/test/API/python_api/signals/TestSignalsAPI.py | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/lldb/bindings/interface/SBUnixSignalsExtensions.i b/lldb/bindings/interface/SBUnixSignalsExtensions.i
index 31c7351f1b5dc..ee6ce43e5075e 100644
--- a/lldb/bindings/interface/SBUnixSignalsExtensions.i
+++ b/lldb/bindings/interface/SBUnixSignalsExtensions.i
@@ -11,7 +11,7 @@
def get_unix_signals_list(self):
signals = []
for idx in range(0, self.GetNumSignals()):
- signals.append(self.GetSignalAtIndex(sig))
+ signals.append(self.GetSignalAtIndex(idx))
return signals
threads = property(get_unix_signals_list, None, doc='''A read only property that returns a list() of valid signal numbers for this platform.''')
diff --git a/lldb/test/API/python_api/signals/TestSignalsAPI.py b/lldb/test/API/python_api/signals/TestSignalsAPI.py
index 4b6c7e4214455..f4c967e4b5692 100644
--- a/lldb/test/API/python_api/signals/TestSignalsAPI.py
+++ b/lldb/test/API/python_api/signals/TestSignalsAPI.py
@@ -50,3 +50,9 @@ def test_ignore_signal(self):
self.assertEqual(
process.GetExitStatus(), 0, "The process should have returned 0"
)
+
+ self.assertIn(
+ sigint,
+ unix_signals.get_unix_signals_list(),
+ "SIGINT should be in the list of supported signals",
+ )
More information about the lldb-commits
mailing list