[Lldb-commits] [lldb] [lldb] std::move unique_ptrs, rather than calling .release. (PR #213525)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Lang Hames (lhames)

<details>
<summary>Changes</summary>

These .release() calls are legacy from the std::auto_ptr to std::unique_ptr transition.

---
Full diff: https://github.com/llvm/llvm-project/pull/213525.diff


1 Files Affected:

- (modified) lldb/source/Expression/IRExecutionUnit.cpp (+2-2) 


``````````diff
diff --git a/lldb/source/Expression/IRExecutionUnit.cpp b/lldb/source/Expression/IRExecutionUnit.cpp
index 49edc2cdc5462..4f18a5da94e10 100644
--- a/lldb/source/Expression/IRExecutionUnit.cpp
+++ b/lldb/source/Expression/IRExecutionUnit.cpp
@@ -50,8 +50,8 @@ IRExecutionUnit::IRExecutionUnit(std::unique_ptr<llvm::LLVMContext> &context_up,
                                  const lldb::TargetSP &target_sp,
                                  const SymbolContext &sym_ctx,
                                  std::vector<std::string> &cpu_features)
-    : IRMemoryMap(target_sp), m_context_up(context_up.release()),
-      m_module_up(module_up.release()), m_module(m_module_up.get()),
+    : IRMemoryMap(target_sp), m_context_up(std::move(context_up)),
+      m_module_up(std::move(module_up)), m_module(m_module_up.get()),
       m_cpu_features(cpu_features), m_name(name), m_sym_ctx(sym_ctx),
       m_did_jit(false), m_function_load_addr(LLDB_INVALID_ADDRESS),
       m_function_end_load_addr(LLDB_INVALID_ADDRESS),

``````````

</details>


https://github.com/llvm/llvm-project/pull/213525