[Lldb-commits] [lldb] [lldb][lldb-server] Update the expected gdbserver's architecture (PR #210946)

[Ebuka Ezike via lldb-commits]

https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/210946

>From fd2c62be728593ab1097abeadee8c2c89f825d1d Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Mon, 20 Jul 2026 19:01:53 +0100
Subject: [PATCH 1/3] [lldb] Update the expected gdbserver's architecture

gdbserver recognises 'x86_64' arch as 'i386:x86-64', this prevents
gdb (binary) from connecting to lldb-server since lldb-server reports
architecture  as 'x86_64'. we already do something similar when
connecting a server to lldb.
This does not affect lldb -> lldb-server since we use qHostInfo to get
that information.
---
 .../GDBRemoteCommunicationServerLLGS.cpp      | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
index 4f11cf8c5475e..a9b9bb160380a 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
@@ -43,6 +43,7 @@
 #include "lldb/Utility/StreamString.h"
 #include "lldb/Utility/UnimplementedError.h"
 #include "lldb/Utility/UriParser.h"
+#include "llvm/ADT/StringSwitch.h"
 #include "llvm/Support/ErrorExtras.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/JSON.h"
@@ -3313,13 +3314,17 @@ GDBRemoteCommunicationServerLLGS::BuildTargetXml() {
   response.IndentMore();
 
   response.Indent();
-  response.Printf("<architecture>%s</architecture>\n",
-                  m_current_process->GetArchitecture()
-                      .GetTriple()
-                      .getArchName()
-                      .str()
-                      .c_str());
-
+  const llvm::StringRef arch_name =
+      m_current_process->GetArchitecture().GetTriple().getArchName();
+  // Match gdbserver's expected architecture name we aready do the same
+  // when decoding the architecture when receiving the target.xml
+  // in ProcessGDBRemote::GetGDBServerRegisterInfoXMLAndProcess.
+  const llvm::StringRef new_arch_name = StringSwitch<llvm::StringRef>(arch_name)
+                                            .Case("x86_64", "i386:x86-64")
+                                            .Case("riscv64", "riscv:rv64")
+                                            .Case("riscv32", "riscv:rv32")
+                                            .Default(arch_name);
+  response.Format("<architecture>{}</architecture>\n", new_arch_name);
   response.Indent("<feature>\n");
 
   const int registers_count = reg_context.GetUserRegisterCount();

>From 03b223b63babd9f2d7ac4372295fbaedad2365ea Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Fri, 31 Jul 2026 11:13:10 +0100
Subject: [PATCH 2/3] update the test target xml test

---
 .../TestGdbRemoteTargetXmlPacket.py                    | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py b/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
index 603aa0033f086..d873fbe04c825 100644
--- a/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
+++ b/lldb/test/API/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py
@@ -40,7 +40,15 @@ def test_g_target_xml_returns_correct_data(self):
 
         architecture = root.find("architecture")
         self.assertIsNotNone(architecture)
-        self.assertIn(self.getArchitecture(), architecture.text)
+        # Match the expected gdbserver's arch, see GDBRemoteCommunicationServerLLGS::BuildTargetXml.
+        replaced_arch = {
+            "x86_64": "i386:x86-64",
+            "riscv64": "riscv:rv64",
+            "riscv32": "riscv:rv32",
+        }
+        arch: str = self.getArchitecture()
+        expected_arch = replaced_arch.get(arch, arch)
+        self.assertIn(architecture.text, expected_arch)
 
         feature = root.find("feature")
         self.assertIsNotNone(feature)

>From 8f8fa20a8bd96c2a35c8d41462fbe813a40732c6 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike <yerimyah1 at gmail.com>
Date: Fri, 31 Jul 2026 11:29:00 +0100
Subject: [PATCH 3/3] update the note

---
 .../Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
index a9b9bb160380a..8fe1674c167ac 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
@@ -3316,8 +3316,8 @@ GDBRemoteCommunicationServerLLGS::BuildTargetXml() {
   response.Indent();
   const llvm::StringRef arch_name =
       m_current_process->GetArchitecture().GetTriple().getArchName();
-  // Match gdbserver's expected architecture name we aready do the same
-  // when decoding the architecture when receiving the target.xml
+  // Match gdbserver's expected architecture. We do the reverse when
+  // decoding the architecture when receiving the target.xml
   // in ProcessGDBRemote::GetGDBServerRegisterInfoXMLAndProcess.
   const llvm::StringRef new_arch_name = StringSwitch<llvm::StringRef>(arch_name)
                                             .Case("x86_64", "i386:x86-64")