[Lldb-commits] [lldb] [lldb][minidump] Don't lose memory after an unreadable page when savi… (PR #212641)

[Jacob Lalonde via lldb-commits]

================
@@ -968,72 +970,55 @@ Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
   const lldb::addr_t addr = range.range.start();
   const lldb::addr_t size = range.range.size();
   Log *log = GetLog(LLDBLog::Object);
-  uint64_t total_bytes_read = 0;
+  void *buf = data_buffer.GetBytes();
----------------
Jlalond wrote:

I'm confused by this refactor. In the description we call out how an unreadable page is corrupting the Minidump. Is this not an error? Any error should stop the ReadInChunks callback.

If it isn't an error, I don't think changing it in Minidump (and coupling the page_size to 4kb) is the right call. Instead this should be implemented in the GDB Server.

@JDevlieghere I'm also curious of your opinion on this

https://github.com/llvm/llvm-project/pull/212641