[Lldb-commits] [lldb] [llvm] [mlir] [DebugInfo] Add symbolic branches to DIExpression (PR #210850)

[Emil Pedersen via lldb-commits]

Snowy1803 wrote:

I think as long as the conflict between DIArgList/OP_LLVM_arg and the branching feature causes a verifier failure, this feature is fragile.
What happens if a frontend creates a DIExpression with branching and without an arglist, and then salvageDebugInfo, through an optimization, rewrites the argument to use an arglist when a binary instruction is deleted? Would it just crash?
I think that if an expression can't be lowered due to an implementation detail, the debug value should just be killed. Hopefully support for DIArgList can be added later.

https://github.com/llvm/llvm-project/pull/210850