[Lldb-commits] [lldb] [lldb][Windows] ignore loader breakpoints in system modules (PR #208233)

[Charles Zablit via lldb-commits]

================
@@ -293,8 +297,12 @@ Status ProcessWindows::DoDestroy() {
 
 Status ProcessWindows::DoHalt(bool &caused_stop) {
   StateType state = GetPrivateState();
-  if (state != eStateStopped)
-    return HaltProcess(caused_stop);
+  if (state != eStateStopped) {
+    m_pending_halt = true;
----------------
charles-zablit wrote:

The Halt comes in as a Debug Exception yes.
It's not a real debug exception, it's just a "virtual breakpoint" that ntdll inserts when a process is spawned halted.
lldb currently treat it as a real breakpoint, which is unexpected to the user, because lldb looks like it hit a breakpoint that does not exist.
The m_pending_halt essentially says "disregard the first halt breakpoint we hit"

https://github.com/llvm/llvm-project/pull/208233