[Lldb-commits] [lldb] [lldb] Update the expected gdbserver's architecture (PR #210946)

[David Spickett via lldb-commits]

================
@@ -3313,13 +3314,17 @@ GDBRemoteCommunicationServerLLGS::BuildTargetXml() {
   response.IndentMore();
 
   response.Indent();
-  response.Printf("<architecture>%s</architecture>\n",
-                  m_current_process->GetArchitecture()
-                      .GetTriple()
-                      .getArchName()
-                      .str()
-                      .c_str());
-
+  const llvm::StringRef arch_name =
+      m_current_process->GetArchitecture().GetTriple().getArchName();
+  // Match gdbserver's expected architecture name we aready do the same
+  // when decoding the architecture when receiving the target.xml
+  // in ProcessGDBRemote::GetGDBServerRegisterInfoXMLAndProcess.
----------------
DavidSpickett wrote:

"Match gdbserver's expected architecture name." - Make that a sentence by adding full stop.

"We do the reverse when decoding the architecture when receiving the target.xml..." - In the context of the code there's no "already" because both will exist.

https://github.com/llvm/llvm-project/pull/210946