[Lldb-commits] [lldb] [lldb] Change DynamicLoaderDarwin::Segment::name type (PR #210797)

[Jason Molenda via lldb-commits]

================
@@ -924,7 +924,7 @@ uint32_t DynamicLoaderMacOSXDYLD::ParseLoadCommands(const DataExtractor &data,
     // starts of file offset zero and that has bytes in the file...
     if ((dylib_info.segments[i].fileoff == 0 &&
          dylib_info.segments[i].filesize > 0) ||
-        (dylib_info.segments[i].name == "__TEXT")) {
+        (llvm::StringRef(dylib_info.segments[i].name) == "__TEXT")) {
----------------
jasonmolenda wrote:

personally i'd just use strcmp here, but creating the stringref temporaries only requires scanning 24 bytes total on both sides, probably not important.

https://github.com/llvm/llvm-project/pull/210797