[Lldb-commits] [lldb] [lldb] Fallback to comparing modules by their canonical paths (PR #210041)

[Charles Zablit via lldb-commits]

================
@@ -1455,6 +1456,25 @@ bool Module::SetLoadAddress(Target &target, lldb::addr_t value,
   return false;
 }
 
+// A module's stored path can be an alias of the same on-disk file that a lookup
+// spec refers to:
+//   - Windows: a subst/mapped drive or a symbolic link
+//   - POSIX: a symbolic link
+// In those cases, MatchesModuleSpec fails even though both name the same file.
+// This is a fall back which compares the canonicalized real paths.
+static bool FileSpecsResolveToSameFile(const FileSpec &pattern,
----------------
charles-zablit wrote:

I fixed the asymmetry, it did not add anything to the table.

https://github.com/llvm/llvm-project/pull/210041