[Lldb-commits] [lldb] [lldb][test] Allow dotest.py to call for Xcode to attach (PR #209628)

[David Mentler via lldb-commits]

================
@@ -381,14 +381,14 @@ def parseOptionsAndInitTestdirs():
             setting_list = setting[0].split("=", 1)
             configuration.settings.append((setting_list[0], setting_list[1]))
 
-    if args.d or args.attach_xcode:
+    if args.d or args.debug_with:
         sys.stdout.write(
             "Suspending the process %d to wait for debugger to attach...\n"
             % os.getpid()
         )
         sys.stdout.flush()
 
-        if args.attach_xcode:
+        if args.debug_with == "xcode":
----------------
mentlerd wrote:

https://docs.python.org/3/library/argparse.html

> Use of [enum.Enum](https://docs.python.org/3/library/enum.html#enum.Enum) is not recommended because it is difficult to control its appearance in usage, help, and error messages.

https://github.com/llvm/llvm-project/pull/209628/commits/463b25c0a53ff8c75ad1934dd67d7235de3e5e9c made `argparse` lowercase the input so incorrect choices are still rejected, but people can call Xcode by its proper name :)

https://github.com/llvm/llvm-project/pull/209628