[Lldb-commits] [lldb] 2975dac - [lldb] Drop support for using the external shell

[via lldb-commits]

Author: Aiden Grossman
Date: 2026-07-15T06:27:59-07:00
New Revision: 2975dac23e684748ae1051e6c1112aa53d7aea2c

URL: https://github.com/llvm/llvm-project/commit/2975dac23e684748ae1051e6c1112aa53d7aea2c
DIFF: https://github.com/llvm/llvm-project/commit/2975dac23e684748ae1051e6c1112aa53d7aea2c.diff

LOG: [lldb] Drop support for using the external shell

The lit external shell is going to be removed soon, so drop support for
using it to run the LLDB tests.

Reviewers: DavidSpickett, JDevlieghere, petrhosek, ilovepi

Pull Request: https://github.com/llvm/llvm-project/pull/209627

Added: 
    

Modified: 
    lldb/test/Shell/helper/toolchain.py
    lldb/test/Shell/lit.cfg.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/Shell/helper/toolchain.py b/lldb/test/Shell/helper/toolchain.py
index c00985a8ef615..8396fabd6e9fd 100644
--- a/lldb/test/Shell/helper/toolchain.py
+++ b/lldb/test/Shell/helper/toolchain.py
@@ -49,10 +49,10 @@ def get_lldb_args(config, suffix=""):
 
 
 class ShTestLldb(ShTest):
-    def __init__(
-        self, execute_external=False, extra_substitutions=[], preamble_commands=[]
-    ):
-        super().__init__(execute_external, extra_substitutions, preamble_commands)
+    def __init__(self, extra_substitutions=[], preamble_commands=[]):
+        super().__init__(
+            extra_substitutions=extra_substitutions, preamble_commands=preamble_commands
+        )
 
     def execute(self, test, litConfig):
         exec_path = test.getExecPath()

diff  --git a/lldb/test/Shell/lit.cfg.py b/lldb/test/Shell/lit.cfg.py
index 238f57b69ff7c..134dba7f1c494 100644
--- a/lldb/test/Shell/lit.cfg.py
+++ b/lldb/test/Shell/lit.cfg.py
@@ -20,16 +20,7 @@
 # name: The name of this test suite.
 config.name = "lldb-shell"
 
-# testFormat: The test format to use to interpret tests.
-# We prefer the lit internal shell which provides a better user experience on
-# failures and is faster unless the user explicitly disables it with
-# LIT_USE_INTERNAL_SHELL=0 env var.
-use_lit_shell = True
-lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL")
-if lit_shell_env:
-    use_lit_shell = lit.util.pythonize_bool(lit_shell_env)
-
-config.test_format = toolchain.ShTestLldb(not use_lit_shell)
+config.test_format = toolchain.ShTestLldb()
 
 # suffixes: A list of file extensions to treat as test files. This is overriden
 # by individual lit.local.cfg files in the test subdirectories.