[Lldb-commits] [lldb] [LLDB] Enable SBTypeSynthetic manipulation for SBValue instances (PR #209056)

[via lldb-commits]

jimingham wrote:

> > You make the claim that you can add a one-off SCP regardless of whether the original ValueObject had an SCP originally or not. But in your test you only add them to ValueObjects representing `std::vector<std::unique_ptr<>>` which already has a SCP. It would be good to add a test where you apply a one-off SCP to something that does NOT already have one to make sure that keeps working as well.
> 
> The test attaches the SCP to `HandleArray`s which are just a plain old struct in the test. I suppose covering the case where there is already an SCP to override could be worth some assertions.

Ah, right, I got it wrong way round.  It would be worth doing the other one whatever the other one actually is...

https://github.com/llvm/llvm-project/pull/209056