[Lldb-commits] [lldb] [lldb-server] Add type info for qMemoryinfo reponse (PR #209235)

[Felipe de Azevedo Piovezan via lldb-commits]

felipepiovezan wrote:

> What you quoted is confusing me because you've quoted a field removed in 4.4, and maybe you have a reason to support that even though it's a 10 year old kernel, but the code is actually parsing this one:
> 
> ```
>               [stack]
>                      The initial process's (also known as the main
>                      thread's) stack.
> ```
> 
> Which doesn't have the TID number in it.
> 
> Please make it clear which one you're looking for.
> 
> This information is in `maps` as well as `smaps`, but having read the code, we're using the same logic to parse the header of a `smaps` entry so it should be fine (and when you were testing it, it was likely reading from `smaps` anyway).

Yup, good catch. I really meant just `[stack]` and was trying to say that this will only work for the main thread _beacuse_ the other field was removed. Let me rephrase things.

https://github.com/llvm/llvm-project/pull/209235