[Lldb-commits] [lldb] [lldb][RISCV] Construct CSR information dynamically (PR #203234)

[Jonas Devlieghere via lldb-commits]

================
@@ -51,8 +57,13 @@ RegisterContextCorePOSIX_riscv32::RegisterContextCorePOSIX_riscv32(
       std::size(g_register_infos_riscv32_gpr);
   constexpr uint32_t k_num_fpr_registers =
       std::size(g_register_infos_riscv32_fpr);
-  constexpr uint32_t k_num_csr_registers =
-      std::size(g_register_infos_riscv32_csr);
+  llvm::SmallVector<std::string> features;
+  GetFeatures(features);
+  llvm::SmallVector<llvm::StringRef> feature_refs(features.begin(),
+                                                  features.end());
----------------
JDevlieghere wrote:

The SmallVector is immediately copied into another one holding different type. Can we have GetCSRegInfos accept an `ArrayRef<std::string>` and drop the second container?

https://github.com/llvm/llvm-project/pull/203234