[Lldb-commits] [lldb] [lldb] Adopt Policy for private/public view and capability decisions (PR #195771)

[David Spickett via lldb-commits]

================
@@ -7,27 +7,40 @@
 //===----------------------------------------------------------------------===//
 
 #include "lldb/Target/Policy.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
 #include "lldb/Utility/Stream.h"
+#include "lldb/Utility/StreamString.h"
 
 using namespace lldb_private;
 
+Policy PolicyStack::Current() const {
+  Policy p = m_stack.back();
+  if (Log *log = GetLog(LLDBLog::Process)) {
----------------
DavidSpickett wrote:

@medismailben This is getting called on every key press, for "example":
```
(lldb) log enable lldb process
(lldb) lldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
elldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
xlldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
alldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
mlldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
plldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
llldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
elldb             policy: view=public, capabilities={eval_expr=true run_all=true try_all=true bp_actions=true frame_providers=true frame_recognizers=true}
```
Which makes it very hard to use lldb when the process log is enabled.

There are some logs that do this but process hasn't been one of them so far.

https://github.com/llvm/llvm-project/pull/195771