[Lldb-commits] [lldb] [lldb] Avoid data race when clearing an OptionValue (PR #208471)

[Ebuka Ezike via lldb-commits]

================
@@ -71,6 +66,11 @@ class OptionValueArch : public Cloneable<OptionValueArch, OptionValue> {
   void SetDefaultValue(const ArchSpec &value) { m_default_value = value; }
 
 protected:
+  void ClearImpl() override {
----------------
da-viper wrote:

Dropped the `ClearImpl` and called the recursive mutex in the derived classes. 
I initially didn't want to expose the mutex but I realised that some of the derived classes may change values not available in the base `OptionValue` and would require a lock. 

https://github.com/llvm/llvm-project/pull/208471