[Lldb-commits] [lldb] [lldb] Don't add the same module to a target twice (PR #208472)

[Charles Zablit via lldb-commits]

charles-zablit wrote:

```
[2026-07-09T15:54:11.292Z] UNRESOLVED: lldb-api :: windows/launch/replace-dll/TestReplaceDLL.py (330 of 3232)
[2026-07-09T15:54:11.292Z] ******************** TEST 'lldb-api :: windows/launch/replace-dll/TestReplaceDLL.py' FAILED ********************
[2026-07-09T15:54:11.292Z] Script:
[2026-07-09T15:54:11.292Z] --
[2026-07-09T15:54:11.292Z] C:\Program Files\Python313\python.exe C:/workspace/llvm-project/lldb\test\API\dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=C:/workspace/llvm-build/./lib --env LLVM_INCLUDE_DIR=C:/workspace/llvm-build/include --env LLVM_TOOLS_DIR=C:/workspace/llvm-build/./bin --triple x86_64-pc-windows-msvc --build-dir C:/workspace/llvm-build/lldb-test-build --lldb-module-cache-dir C:/workspace/llvm-build/lldb-test-build/module-cache-lldb\lldb-api --clang-module-cache-dir C:/workspace/llvm-build/lldb-test-build/module-cache-clang\lldb-api --executable C:/workspace/llvm-build/./bin/lldb.exe --lldb-python-dir C:\workspace\llvm-build\Lib\site-packages --compiler C:/workspace/llvm-build/./bin/clang.exe --dsymutil C:/workspace/llvm-build/./bin/dsymutil.exe --make C:/GnuWin32Make-4.4.1/bin/make.exe --llvm-tools-dir C:/workspace/llvm-build/./bin --lldb-obj-root C:/workspace/llvm-build/tools/lldb --lldb-libs-dir C:/workspace/llvm-build/./lib --cmake-build-type Release --env LLDB_LAUNCH_FLAG_USE_PIPES=1 C:\workspace\llvm-project\lldb\test\API\windows\launch\replace-dll -p TestReplaceDLL.py
[2026-07-09T15:54:11.292Z] --
[2026-07-09T15:54:11.292Z] Exit Code: 1
[2026-07-09T15:54:11.292Z] 
[2026-07-09T15:54:11.292Z] Command Output (stdout):
[2026-07-09T15:54:11.292Z] --
[2026-07-09T15:54:11.292Z] Connection established.
[2026-07-09T15:54:11.292Z] lldb-server-local_build
[2026-07-09T15:54:11.292Z] Launched 'C:\workspace\llvm-build\lldb-test-build\windows\launch\replace-dll\TestReplaceDLL.test_dwarf\a.out' as process 13272...
[2026-07-09T15:54:11.292Z] Skipping the following test categories: libc++, libstdcxx, dwo, dsym, gmodules, debugserver, objc, fork, pexpect

[2026-07-09T15:54:11.292Z] 
[2026-07-09T15:54:11.292Z] --
[2026-07-09T15:54:11.292Z] Command Output (stderr):
[2026-07-09T15:54:11.292Z] --
[2026-07-09T15:54:11.292Z] UNSUPPORTED: LLDB (C:\workspace\llvm-build\bin\clang.exe-x86_64) :: test_dsym (TestReplaceDLL.ReplaceDllTestCase.test_dsym) (test case does not fall in any category of interest for this run) 

[2026-07-09T15:54:11.292Z] lldb-server exiting...

[2026-07-09T15:54:11.292Z] FAIL: LLDB (C:\workspace\llvm-build\bin\clang.exe-x86_64) :: test_dwarf (TestReplaceDLL.ReplaceDllTestCase.test_dwarf)

[2026-07-09T15:54:11.292Z] Log Files:

[2026-07-09T15:54:11.292Z]  - C:\workspace\llvm-build\lldb-test-build\windows\launch\replace-dll\TestReplaceDLL.test_dwarf\Error_test_dwarf.log

[2026-07-09T15:54:11.292Z] UNSUPPORTED: LLDB (C:\workspace\llvm-build\bin\clang.exe-x86_64) :: test_dwo (TestReplaceDLL.ReplaceDllTestCase.test_dwo) (test case does not fall in any category of interest for this run) 

[2026-07-09T15:54:11.292Z] ======================================================================

[2026-07-09T15:54:11.292Z] ERROR: test_dwarf (TestReplaceDLL.ReplaceDllTestCase.test_dwarf)

[2026-07-09T15:54:11.292Z]    Test that LLDB unlocks module files once all references are released.

[2026-07-09T15:54:11.292Z] ----------------------------------------------------------------------

[2026-07-09T15:54:11.292Z] Traceback (most recent call last):

[2026-07-09T15:54:11.292Z]   File "C:\workspace\llvm-project\lldb\packages\Python\lldbsuite\test\lldbtest.py", line 2186, in test_method

[2026-07-09T15:54:11.292Z]     return attrvalue(self)

[2026-07-09T15:54:11.292Z]   File "C:\workspace\llvm-project\lldb\test\API\windows\launch\replace-dll\TestReplaceDLL.py", line 58, in test

[2026-07-09T15:54:11.292Z]     os.remove(foo)

[2026-07-09T15:54:11.292Z]     ~~~~~~~~~^^^^^

[2026-07-09T15:54:11.292Z] PermissionError: [WinError 5] Access is denied: 'C:\\workspace\\llvm-build\\lldb-test-build\\windows\\launch\\replace-dll\\TestReplaceDLL.test_dwarf\\foo.dll'

[2026-07-09T15:54:11.292Z] Config=x86_64-C:\workspace\llvm-build\bin\clang.exe

[2026-07-09T15:54:11.292Z] ----------------------------------------------------------------------

[2026-07-09T15:54:11.292Z] Ran 3 tests in 3.618s

[2026-07-09T15:54:11.292Z] 

[2026-07-09T15:54:11.292Z] FAILED (errors=1, skipped=2)

[2026-07-09T15:54:11.292Z] 
[2026-07-09T15:54:11.292Z] --
[2026-07-09T15:54:11.292Z] 
[2026-07-09T15:54:11.292Z] ********************
```

https://github.com/llvm/llvm-project/pull/208472