[Lldb-commits] [lldb] [lldb] Don't add the same module to a target twice (PR #208472)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 33994 tests passed
* 545 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### lldb-shell
<details>
<summary>lldb-shell.Commands/command-module-hook-fire.test</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 4
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution --target=x86_64-unknown-linux-gnu -pthread -fmodules-cache-path=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lldb-test-build/module-cache-clang/lldb-shell -g /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/Inputs/main.c -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang --target=specify-a-target-or-use-a-_host-substitution --target=x86_64-unknown-linux-gnu -pthread -fmodules-cache-path=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lldb-test-build/module-cache-clang/lldb-shell -g /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/Inputs/main.c -o /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp
# .---command stderr------------
# | clang: warning: argument unused during compilation: '-fmodules-cache-path=/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lldb-test-build/module-cache-clang/lldb-shell' [-Wunused-command-line-argument]
# `-----------------------------
# RUN: at line 5
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/lldb --no-lldbinit -S /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet -b -o 'file /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp'    -o 'target hook add -L -o "script print(\"HOOK_FIRED\")"'    -o 'target modules add /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp'    2>&1 | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-module-hook-fire.test
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/lldb --no-lldbinit -S /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet -b -o 'file /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp' -o 'target hook add -L -o "script print(\"HOOK_FIRED\")"' -o 'target modules add /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp'
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-module-hook-fire.test
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-module-hook-fire.test:11:10: error: CHECK: expected string not found in input
# | # CHECK: HOOK_FIRED
# |          ^
# | <stdin>:7:15: note: scanning from here
# | Hook #1 added.
# |               ^
# | <stdin>:8:48: note: possible intended match here
# | (lldb) target modules add /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp
# |                                                ^
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/lldb/test/Shell/Commands/command-module-hook-fire.test
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             1: (lldb) command source -s 0 '/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet' 
# |             2: Executing commands in '/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/lit-lldb-init-quiet'. 
# |             3: (lldb) command source -C --silent-run true lit-lldb-init 
# |             4: (lldb) file /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp 
# |             5: Current executable set to '/home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp' (x86_64). 
# |             6: (lldb) target hook add -L -o "script print(\"HOOK_FIRED\")" 
# |             7: Hook #1 added. 
# | check:11'0                  {   search range start (exclusive)
# | check:11'1                      error: no match found in search range
# |             8: (lldb) target modules add /home/gha/actions-runner/_work/llvm-project/llvm-project/build/tools/lldb/test/Shell/Commands/Output/command-module-hook-fire.test.tmp 
# | check:11'2                                                    ?                                                                                                                   possible intended match
# | check:11'3                                                                                                                                                                      } search range end (exclusive)
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/208472