[Lldb-commits] [lldb] [lldb] Fix SymbolFilePDBTests after FileSpec change f9b5264523b1 (PR #208425)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Stefan Gränitz (weliveindetail)

<details>
<summary>Changes</summary>

GetDirectory() returns a StringRef now which doesn't convert to bool implicitly. This breaks compilation of the check-lldb target: `binary '&&': no operator found which takes a left-hand operand of type 'llvm::StringRef'`

---
Full diff: https://github.com/llvm/llvm-project/pull/208425.diff


1 Files Affected:

- (modified) lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp (+1-1) 


``````````diff
diff --git a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
index 7dd0a4a0f1871..bb1e0d8cd1fea 100644
--- a/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
+++ b/lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
@@ -94,7 +94,7 @@ class SymbolFilePDBTests : public testing::Test {
     if (!left.FileEquals(right))
       return false;
     // If BOTH have a directory, also compare the directories.
-    if (left.GetDirectory() && right.GetDirectory())
+    if (!left.GetDirectory().empty() && !right.GetDirectory().empty())
       return left.DirectoryEquals(right);
 
     // If one has a directory but not the other, they match.

``````````

</details>


https://github.com/llvm/llvm-project/pull/208425