[Lldb-commits] [lldb] [lldb-dap] Migrate lldb-dap tests in `lldb-dap/breakpoint` (PR #208166)

[Sergei Druzhkov via lldb-commits]

================
@@ -114,91 +100,64 @@ def test_logmessage_advanced(self):
             logMessage_prefix
             + "{int y = 0; if (i % 3 == 0) { y = i + 3;} else {y = i * 3;} y}"
         )
-        [loop_breakpoint_id, post_loop_breakpoint_id] = self.set_source_breakpoints(
+        [_, post_loop_breakpoint_id] = session.resolve_source_breakpoints(
             self.main_path,
-            [loop_line, after_loop_line],
-            [{"logMessage": logMessage}, {}],
+            [
+                SourceBreakpoint(before_loop_line, logMessage=logMessage),
+                SourceBreakpoint(after_loop_line),
+            ],
         )
 
-        # Continue to trigger the breakpoint with log messages
-        self.dap_server.request_continue()
-
-        # Verify we hit the breakpoint after loop line
-        self.verify_breakpoint_hit([post_loop_breakpoint_id])
-
-        output = self.get_console()
-        lines = output.splitlines()
-        logMessage_output = []
-        for line in lines:
-            if line.startswith(logMessage_prefix):
-                logMessage_output.append(line)
-
-        # Verify logMessage count
-        loop_count = 10
-        self.assertEqual(len(logMessage_output), loop_count)
-
-        # Verify log message match
+        post_loop_stop = session.continue_to_breakpoint(post_loop_breakpoint_id)
+        captured = session.collect_console(after=initial_stop, until=post_loop_stop)
+        logMessage_output = [
+            line
+            for line in captured.seen_texts.splitlines()
+            if line.startswith(logMessage_prefix)
+        ]
----------------
DrSergei wrote:

I see some repetions of this pattern, maybe we can create helper function to do this work

https://github.com/llvm/llvm-project/pull/208166