[Lldb-commits] [lldb] [lldb-dap] Migrate DAP launch tests (PR #207023)

[John Harrison via lldb-commits]

================
@@ -2,41 +2,41 @@
 Test lldb-dap launch request.
 """
 
-from lldbsuite.test.decorators import expectedFailureWindows
-import lldbdap_testcase
+from lldbsuite.test.decorators import skipIfWindows
+from lldbsuite.test.tools.lldb_dap.dap_types import LaunchArgs
+from lldbsuite.test.tools.lldb_dap.lldb_dap_testcase import DAPTestCaseBase
 
 
-class TestDAP_launch(lldbdap_testcase.DAPTestCaseBase):
-    def test_environment_with_object(self):
-        """
-        Tests launch of a simple program with environment variables
-        """
+class TestDAP_launch_environment_with_object(DAPTestCaseBase):
+    """
+    Tests launch of a simple program with environment variables
+    """
+
+    @skipIfWindows
+    def test(self):
         program = self.getBuildArtifact("a.out")
-        env = {
+        expected_env = {
             "NO_VALUE": "",
----------------
ashgti wrote:

Should this line be `None` or something? The 'NO_VALUE' vs. 'EMPTY_VALUE' entries make it seem like that was meant to be the case but at some point this might have gotten lost in a refactor.

https://github.com/llvm/llvm-project/pull/207023