[Lldb-commits] [lldb] [lldb][test] Always kill test processes (PR #207181)

[David Spickett via lldb-commits]

https://github.com/DavidSpickett approved this pull request.

The only way this would be unsafe is if we attached to a process that was not created by or as a result of a test case. I don't know of any and if there are any it would in fact be a good thing if this change found them accidentally.

So LGTM.

What's your theory on how the flakey test happened then? Do you think one test method in that file created the first process, detached from it, and moved to the next test method before the first process naturally ended? And by now killing that process, we know it'll be gone by the time the next test method runs.

https://github.com/llvm/llvm-project/pull/207181