[Lldb-commits] [lldb] [lldb] Tighten TestFrameProviderCircularDependency loop (PR #206987)
Charles Zablit via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 1 07:05:45 PDT 2026
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/206987
>From cd3818a1de13caf0011b294371da792f06375b71 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Wed, 1 Jul 2026 14:48:25 +0100
Subject: [PATCH 1/2] [lldb] Tighten TestFrameProviderCircularDependency loop
---
.../circular_dependency/TestFrameProviderCircularDependency.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py b/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py
index 87a30c150e4e3..9f0f994458823 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py
@@ -115,7 +115,7 @@ def test_circular_dependency_with_function_replacement(self):
)
# Verify we can call methods on all frames (no circular dependency!).
- for i in range(new_frame_count):
+ for i in range(min(new_frame_count, 3)):
frame = thread.GetFrameAtIndex(i)
self.assertIsNotNone(frame, f"Frame {i} should exist")
# These calls should not trigger circular dependency.
>From a12609b366db430f104dff050f07b27b774eac46 Mon Sep 17 00:00:00 2001
From: Charles Zablit <c_zablit at apple.com>
Date: Wed, 1 Jul 2026 15:05:32 +0100
Subject: [PATCH 2/2] fixup! [lldb] Tighten TestFrameProviderCircularDependency
loop
---
.../circular_dependency/TestFrameProviderCircularDependency.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py b/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py
index 9f0f994458823..6563a4003b1ed 100644
--- a/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py
+++ b/lldb/test/API/functionalities/scripted_frame_provider/circular_dependency/TestFrameProviderCircularDependency.py
@@ -47,7 +47,6 @@ def launch_and_stop_at_breakpoint(self):
return target, thread
@expectedFailureAll(oslist=["linux"], archs=["arm$"])
- @expectedFailureWindowsAndNoLLDBServer(bugnumber="llvm.org/pr24778")
def test_circular_dependency_with_function_replacement(self):
"""
Test the circular dependency fix with a provider that replaces function names.
More information about the lldb-commits
mailing list