[Lldb-commits] [lldb] [lldb] Return llvm::Error from EnableLogChannel (PR #206479)

[David Spickett via lldb-commits]

================
@@ -1642,11 +1642,10 @@ bool SBDebugger::EnableLog(const char *channel, const char **categories) {
   if (m_opaque_sp) {
     uint32_t log_options =
         LLDB_LOG_OPTION_PREPEND_TIMESTAMP | LLDB_LOG_OPTION_PREPEND_THREAD_NAME;
-    std::string error;
-    llvm::raw_string_ostream error_stream(error);
-    return m_opaque_sp->EnableLog(channel, GetCategoryArray(categories), "",
-                                  log_options, /*buffer_size=*/0,
-                                  eLogHandlerStream, error_stream);
+    llvm::Error err = m_opaque_sp->EnableLog(
+        channel, GetCategoryArray(categories), "", log_options,
+        /*buffer_size=*/0, eLogHandlerStream);
+    return !bool(err);
----------------
DavidSpickett wrote:

This is now fixed, I do need to consume the error.

https://github.com/llvm/llvm-project/pull/206479