[Lldb-commits] [lldb] [lldb][Windows] Add SVE register read/write support in lldb-server (PR #205906)

[Ayush Sahay via lldb-commits]

================
@@ -58,6 +69,39 @@ def _is_supported_darwin(self, cmd_runner):
 
         return None, (output.strip() == "1")
 
+    # PowerShell may not be on PATH on minimal Windows images, and Add-Type
+    # requires the .NET CLR and the CSC compiler to be available. Neither is
+    # guaranteed.
+    # TODO: Replace the PowerShell chain with a probe that calls
+    # 'IsProcessorFeaturePresent' directly.
----------------
ayushsahay1837 wrote:

Thanks for the suggestion! _ctypes.windll.kernel32.IsProcessorFeaturePresent(PF_ARM_SVE_INSTRUCTIONS_AVAILABLE)_ returns _1_ if the underlying hardware supports SVE and _0_ otherwise. That said, it looks like the runner used to execute commands on the active platform cannot parse the command line correctly. Using the runner to execute the command ensures that it's executed locally or remotely as appropriate. Nevertheless, I think that a native probe executable built on the fly and run through the runner would be a stronger alternative to both the PowerShell chain and _ctypes_. What do you think?

https://github.com/llvm/llvm-project/pull/205906