[Lldb-commits] [lldb] [lldb][Windows] use Unicode path limit (PR #206060)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Charles Zablit (charles-zablit)

<details>
<summary>Changes</summary>

`MAX_PATH` is defined as `260`. `PosixApi.h` already defines `PATH_MAX` as `32,768` characters which is the max path limit for Unicode paths on Windows.

Use this in lldb on Windows to avoid path truncation.

---
Full diff: https://github.com/llvm/llvm-project/pull/206060.diff


1 Files Affected:

- (modified) lldb/tools/driver/Platform.h (+1-5) 


``````````diff
diff --git a/lldb/tools/driver/Platform.h b/lldb/tools/driver/Platform.h
index ff017c4422b12..f2491dcf399bb 100644
--- a/lldb/tools/driver/Platform.h
+++ b/lldb/tools/driver/Platform.h
@@ -28,9 +28,6 @@ typedef unsigned char cc_t;
 typedef unsigned int speed_t;
 typedef unsigned int tcflag_t;
 
-// fcntl.h
-#define O_NOCTTY 0400
-
 // ioctls.h
 #define TIOCGWINSZ 0x5413
 
@@ -60,8 +57,7 @@ struct timeval {
   long tv_sec;
   long tv_usec;
 };
-typedef long pid_t;
-#define PATH_MAX MAX_PATH
+#include "lldb/Host/PosixApi.h"
 #endif
 
 #define STDIN_FILENO 0

``````````

</details>


https://github.com/llvm/llvm-project/pull/206060