[Lldb-commits] [lldb] [lldb][Mach-O] Fix load-command loops spinning on cmdsize = 0 (PR #205134)

[via lldb-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/lldb/unittests/ObjectContainer/CMakeFiles/ObjectContainerTests.dir/ObjectContainerUniversalMachOTest.cpp.obj</summary>

```
FAILED: [code=1] tools/lldb/unittests/ObjectContainer/CMakeFiles/ObjectContainerTests.dir/ObjectContainerUniversalMachOTest.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DLLVM_BUILD_STATIC -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_ENABLE_EXTENDED_ALIGNED_STORAGE -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\lldb\unittests\ObjectContainer -IC:\_work\llvm-project\llvm-project\lldb\unittests\ObjectContainer -IC:\_work\llvm-project\llvm-project\lldb\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -IC:\_work\llvm-project\llvm-project\llvm\..\clang\include -IC:\_work\llvm-project\llvm-project\build\tools\lldb\..\clang\include -IC:\_work\llvm-project\llvm-project\lldb\source -IC:\_work\llvm-project\llvm-project\lldb\unittests -IC:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include -IC:\_work\llvm-project\llvm-project\third-party\unittest\googlemock\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-vla-extension /O2 /Ob2  -std:c++17 -MD   -wd4018 -wd4068 -wd4150 -wd4201 -wd4251 -wd4521 -wd4530 -wd4589 -UNDEBUG -Wno-suggest-override -Wno-gnu-zero-variadic-macro-arguments /EHs-c- /GR- /showIncludes /Fotools\lldb\unittests\ObjectContainer\CMakeFiles\ObjectContainerTests.dir\ObjectContainerUniversalMachOTest.cpp.obj /Fdtools\lldb\unittests\ObjectContainer\CMakeFiles\ObjectContainerTests.dir\ -c -- C:\_work\llvm-project\llvm-project\lldb\unittests\ObjectContainer\ObjectContainerUniversalMachOTest.cpp
C:\_work\llvm-project\llvm-project\lldb\unittests\ObjectContainer\ObjectContainerUniversalMachOTest.cpp(195,1): error: static data member 'test_info_' not allowed in local class 'ObjectContainerUniversalMachOTest_NfatArchTruncatedSlices_Test'
195 | TEST_F(ObjectContainerUniversalMachOTest, NfatArchTruncatedSlices) {
| ^
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest.h(2208,41): note: expanded from macro 'TEST_F'
2208 | #define TEST_F(test_fixture, test_name) GTEST_TEST_F(test_fixture, test_name)
|                                         ^
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/gtest.h(2205,3): note: expanded from macro 'GTEST_TEST_F'
2205 |   GTEST_TEST_(test_fixture, test_name, test_fixture, \
|   ^
C:\_work\llvm-project\llvm-project\third-party\unittest\googletest\include\gtest/internal/gtest-internal.h(1544,39): note: expanded from macro 'GTEST_TEST_'
1544 |     static ::testing::TestInfo* const test_info_ GTEST_ATTRIBUTE_UNUSED_;      \
|                                       ^
C:\_work\llvm-project\llvm-project\lldb\unittests\ObjectContainer\ObjectContainerUniversalMachOTest.cpp(195,68): error: function definition is not allowed here
195 | TEST_F(ObjectContainerUniversalMachOTest, NfatArchTruncatedSlices) {
|                                                                    ^
C:\_work\llvm-project\llvm-project\lldb\unittests\ObjectContainer\ObjectContainerUniversalMachOTest.cpp(215,2): error: expected '}'
215 | }
|  ^
C:\_work\llvm-project\llvm-project\lldb\unittests\ObjectContainer\ObjectContainerUniversalMachOTest.cpp(135,54): note: to match this '{'
135 | TEST_F(ObjectContainerMachOFilesetTest, ZeroCmdSize) {
|                                                      ^
3 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/205134