[Lldb-commits] [lldb] [lldb] Remove ConstString from FileSpec setters (PR #205944)

[via lldb-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/205944.diff


2 Files Affected:

- (modified) lldb/include/lldb/Utility/FileSpec.h (-2) 
- (modified) lldb/source/Utility/FileSpec.cpp (-10) 


``````````diff
diff --git a/lldb/include/lldb/Utility/FileSpec.h b/lldb/include/lldb/Utility/FileSpec.h
index 9140e98c880a2..db6dd57c9cfc5 100644
--- a/lldb/include/lldb/Utility/FileSpec.h
+++ b/lldb/include/lldb/Utility/FileSpec.h
@@ -237,7 +237,6 @@ class FileSpec {
   ///
   /// \param[in] directory
   ///     The value to replace the directory with.
-  void SetDirectory(ConstString directory);
   void SetDirectory(llvm::StringRef directory);
 
   /// Clear the directory in this object.
@@ -253,7 +252,6 @@ class FileSpec {
   ///
   /// \param[in] filename
   ///     The const string to replace the directory with.
-  void SetFilename(ConstString filename);
   void SetFilename(llvm::StringRef filename);
 
   /// Clear the filename in this object.
diff --git a/lldb/source/Utility/FileSpec.cpp b/lldb/source/Utility/FileSpec.cpp
index 0498dddb37458..820939fe610c7 100644
--- a/lldb/source/Utility/FileSpec.cpp
+++ b/lldb/source/Utility/FileSpec.cpp
@@ -339,21 +339,11 @@ llvm::json::Value FileSpec::ToJSON() const {
 
 FileSpec::Style FileSpec::GetPathStyle() const { return m_style; }
 
-void FileSpec::SetDirectory(ConstString directory) {
-  m_directory = directory;
-  PathWasModified();
-}
-
 void FileSpec::SetDirectory(llvm::StringRef directory) {
   m_directory = ConstString(directory);
   PathWasModified();
 }
 
-void FileSpec::SetFilename(ConstString filename) {
-  m_filename = filename;
-  PathWasModified();
-}
-
 void FileSpec::SetFilename(llvm::StringRef filename) {
   m_filename = ConstString(filename);
   PathWasModified();

``````````

</details>


https://github.com/llvm/llvm-project/pull/205944