[Lldb-commits] [lldb] e87160e - [lldb] Fix DWARFASTParserClang formatting (#205857)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 25 10:02:14 PDT 2026
Author: Jonas Devlieghere
Date: 2026-06-25T17:02:09Z
New Revision: e87160eddf6d7986423209711878b26f82443009
URL: https://github.com/llvm/llvm-project/commit/e87160eddf6d7986423209711878b26f82443009
DIFF: https://github.com/llvm/llvm-project/commit/e87160eddf6d7986423209711878b26f82443009.diff
LOG: [lldb] Fix DWARFASTParserClang formatting (#205857)
In #205701, I applied Michael's suggestion and enabled auto-merge.
Despite the formatter check failing, the change still got merged. Fix
the formatting and another inconsistency in the use of braces.
Added:
Modified:
lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Removed:
################################################################################
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
index f4d3f87331a88..0506b7d4da40f 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
@@ -2489,20 +2489,21 @@ Function *DWARFASTParserClang::ParseFunctionFromDWARF(
} else if (mangled) {
func_name.SetValue(ConstString(mangled));
} else if ((die.GetParent().Tag() == DW_TAG_compile_unit ||
- die.GetParent().Tag() == DW_TAG_partial_unit) &&
- Language::LanguageIsCPlusPlus(
- SymbolFileDWARF::GetLanguage(*die.GetCU())) &&
- !Language::LanguageIsObjC(
- SymbolFileDWARF::GetLanguage(*die.GetCU())) &&
- name && strcmp(name, "main") != 0) {
+ die.GetParent().Tag() == DW_TAG_partial_unit) &&
+ Language::LanguageIsCPlusPlus(
+ SymbolFileDWARF::GetLanguage(*die.GetCU())) &&
+ !Language::LanguageIsObjC(
+ SymbolFileDWARF::GetLanguage(*die.GetCU())) &&
+ name && strcmp(name, "main") != 0) {
// If the mangled name is not present in the DWARF, generate the
// demangled name using the decl context. We skip if the function is
// "main" as its name is never mangled.
func_name.SetDemangledName(ConstructDemangledNameFromDWARF(die));
// Ensure symbol is preserved (as the mangled name).
func_name.SetMangledName(ConstString(name));
- } else
+ } else {
func_name.SetValue(ConstString(name));
+ }
FunctionSP func_sp;
More information about the lldb-commits
mailing list