[Lldb-commits] [lldb] [lldb][gdb-remote] Send QSetSTDIOWindowSize for a 0x0 size (PR #205772)

via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 25 04:21:17 PDT 2026


================
@@ -2039,7 +2039,7 @@ int GDBRemoteCommunicationClient::SetSTDERR(const FileSpec &file_spec) {
 
 int GDBRemoteCommunicationClient::SetSTDIOWindowSize(uint16_t cols,
                                                      uint16_t rows) {
-  if (cols == 0 || rows == 0)
+  if ((cols == 0) != (rows == 0))
----------------
Nerixyz wrote:

A comment like "0x0 is a valid size." would be helpful.

This runs on all platforms. Do non-Windows platforms support a 0x0 size?

https://github.com/llvm/llvm-project/pull/205772


More information about the lldb-commits mailing list