[Lldb-commits] [lldb] [lldb] Ignore notification packets (PR #204788)

[David Spickett via lldb-commits]

================
@@ -839,6 +853,30 @@ GDBRemoteCommunication::CheckForPacket(const uint8_t *src, size_t src_len,
   return GDBRemoteCommunication::PacketType::Invalid;
 }
 
+GDBRemoteCommunication::PacketType
+GDBRemoteCommunication::CheckForPacketIgnoreNotifications(
----------------
DavidSpickett wrote:

I don't think I would have objected to changing CheckForPacket itself to reject notifications, but I do like the super clear naming here.

I assume all callers of CheckForPacket are either the one here in CheckForPacketIgnoreNotifications, unit tests for CheckForPacket, or something with a really good reason not to ignore notifications. Is that right?

https://github.com/llvm/llvm-project/pull/204788