[Lldb-commits] [lldb] [LLDB] Serve unknown type symbols through `qSymbol` (PR #200134)

[David Spickett via lldb-commits]

================
@@ -4276,6 +4278,19 @@ void GDBRemoteCommunicationClient::ServeSymbolLookups(
                   case eSymbolTypeCompiler:
                   case eSymbolTypeInstrumentation:
                   case eSymbolTypeTrampoline:
+                    if (sc.module_sp->GetArchitecture()
+                            .GetTriple()
+                            .getObjectFormat() ==
+                        llvm::Triple::ObjectFormatType::MachO) {
----------------
DavidSpickett wrote:

This condition seems inverted. Shouldn't it be if we're not using MachO we return the value for these symbol types?

https://github.com/llvm/llvm-project/pull/200134